Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc]fix ondisk_dataset_homograph.ipynb #7258

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

MikuSugar
Copy link
Contributor

@MikuSugar MikuSugar commented Apr 2, 2024

Description

When I was learning(https://docs.dgl.ai/stochastic_training/ondisk_dataset_homograph.html) to build the Graphbolt local data set, the data built according to the document tutorial code had an error when calculating the AUC in the link prediction task.
Fix data generation for lp_test_dode_pairs
"lp_test_node_pairs = edges[-num_tests, :] to lp_test_node_pairs = edges[-num_tests:, :] "
Refer to #7252

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 2, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 2, 2024

Commit ID: 127f1cc

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@MikuSugar
Copy link
Contributor Author

Hi ,@Rhett-Ying Thank you, I have resubmitted a PR as recommended.

@Rhett-Ying Rhett-Ying self-requested a review April 3, 2024 00:20
@Rhett-Ying
Copy link
Collaborator

Thanks for your contribution

@Rhett-Ying Rhett-Ying merged commit c5e683c into dmlc:master Apr 3, 2024
1 of 2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants