Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Minibatch.to() patch. #7330

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Apr 19, 2024

Description

Details in #7315. In this PR, we ensure that we do not call properties of the minibatch object when filtering its attributes. The CPU usage is still high, we might want to continue the investigation. PyG advanced example regression is mostly resolved though.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin marked this pull request as draft April 19, 2024 07:31
@mfbalin mfbalin marked this pull request as ready for review April 19, 2024 07:43
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 3ff780e

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 46d949e

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 03f4bf8

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from Rhett-Ying April 19, 2024 07:54
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 80e60f3

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 769900c

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 75eed6d

Build ID: 6

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 19, 2024

Commit ID: 75eed6d

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin added the Release Blocker Issues that blocks release label Apr 20, 2024
@mfbalin mfbalin merged commit 324fd97 into dmlc:master Apr 20, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_MiniBatch_to_patch branch April 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Blocker Issues that blocks release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants