Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Remove unused attributes in minibatch. #7337

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented Apr 22, 2024

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 22, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@yxy235 yxy235 force-pushed the remove_unused_attributes_in_minibatch branch from 8d805b5 to 45496f2 Compare April 22, 2024 03:39
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 22, 2024

Commit ID: 8d805b5

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@yxy235 yxy235 marked this pull request as ready for review April 22, 2024 03:41
@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 22, 2024

Commit ID: 45496f2

Build ID: 2

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Apr 22, 2024

Commit ID: 41f81d5

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@yxy235 yxy235 merged commit 697a997 into dmlc:master Apr 22, 2024
2 checks passed
@yxy235 yxy235 deleted the remove_unused_attributes_in_minibatch branch April 30, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants