Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] GPUCachedFeature update fix. #7384

Merged
merged 10 commits into from
May 9, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented May 9, 2024

Description

Fixes #7377. I realized there was an issue with the modified PyG advanced example. I will use the cache version in the DGL 2.2 release blog so I would like to merge the example change too.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the Release Candidate Candidate PRs for the upcoming release label May 9, 2024
@mfbalin mfbalin requested a review from frozenbugs May 9, 2024 02:51
@mfbalin mfbalin marked this pull request as draft May 9, 2024 02:51
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin self-assigned this May 9, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 6e46c56

Build ID: 1

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review May 9, 2024 03:49
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 2279907

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: dab096a

Build ID: 3

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@mfbalin mfbalin force-pushed the gb_cuda_gpu_cache_feature_update_bug branch from 9370208 to fe917bf Compare May 9, 2024 04:58
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 9370208

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: fe917bf

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 6e0bcc9

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: b908775

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from Rhett-Ying May 9, 2024 06:27
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 8b0b708859842e1c2c5334f03c352ebe97bfb2cd

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: e47f20f

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from Rhett-Ying May 9, 2024 08:03
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: e47f20f

Build ID: 10

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: 66a954d

Build ID: 11

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 9, 2024

Commit ID: d2e41f8

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit fb36b47 into dmlc:master May 9, 2024
2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Candidate Candidate PRs for the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt][CUDA] GPUCachedFeature update bug when feature dimensions differ
4 participants