Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fix blocks in minibatch when facing with empty edges in subgraph. #7413

Merged
merged 24 commits into from
Jun 13, 2024

Conversation

yxy235
Copy link
Collaborator

@yxy235 yxy235 commented May 16, 2024

Description

related to #7410

TODO:

  1. add test case: get blocks from homo graph minibatch
  2. add test case: check if node type of seeds still occurs in src_node_type of edges, it will always be passed down.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2024

Commit ID: 2e7b62e

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2024

Commit ID: 2bd775c

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2024

Commit ID: ddb12da

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2024

Commit ID: a382232

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@Skeleton003 please work on this PR. the code change in python core is done. you just need to add more testcases, just cover all possible scenarios we may hit. Please refer to the description for the issue this PR is targeting on.

TODO:

add test case: get blocks from homo graph minibatch
add test case: check if node type of seeds still occurs in src_node_type of edges, it will always be passed down.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 8, 2024

Commit ID: a1875a124bdc1295a51cdb4b18d479e1cc25f104

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 8, 2024

Commit ID: d98f5d7724894240439d32625482e6a19e72dae2

Build ID: 6

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 9, 2024

Commit ID: b04c7db27970c4a046765c1ae496180152d9f0de

Build ID: 7

Status: ❌ CI test failed in Stage [Torch CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 9, 2024

Commit ID: 2decac0

Build ID: 8

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 10, 2024

Commit ID: e5d9daa

Build ID: 9

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 11, 2024

Commit ID: 27d5eca

Build ID: 10

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@Skeleton003 Skeleton003 self-assigned this Jun 12, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 12, 2024

Commit ID: 84af196

Build ID: 11

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 546891d

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 85b2cb5

Build ID: 13

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2024

Commit ID: 85b2cb5

Build ID: 14

Status: ❌ CI test failed in Stage [Distributed Torch CPU Unit test].

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit e489e38 into dmlc:master Jun 13, 2024
1 of 2 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GraphBolt] SampledCSC with empty edges for some etype crashes in create_block()
4 participants