Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UserWarning] Fixing the warnings appearing in test_nn.py::test_group_rev_res. #7486

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

drivanov
Copy link
Contributor

Description

The following warnings that appear in test_nn.py::test_group_rev_res have been fixed:

tests/python/pytorch/nn/test_nn.py::test_group_rev_res[idtype0]
/usr/local/lib/python3.10/dist-packages/dgl/nn/pytorch/conv/grouprevres.py:35: UserWarning: TypedStorage is deprecated. 
It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you 
if you are using storages directly.  To access UntypedStorage directly, use tensor.untyped_storage() instead 
of tensor.storage()

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 26, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 26, 2024

Commit ID: 8cc5c90

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator

mfbalin commented Jun 27, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 27, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 27, 2024

Commit ID: 6754787

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 27, 2024

Commit ID: 62bc5a042aab077342e73a7118dcf78f78cb5bed

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator

mfbalin commented Jun 28, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2024

Commit ID: 6754787

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 65b949f into dmlc:master Jul 1, 2024
2 checks passed
@drivanov drivanov deleted the untyped branch July 1, 2024 16:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants