Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] gb.TemporalLayerNeighborSampler #7503

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 4, 2024

Description

TODO: TemporalNeighborSamplerImpl needs to be refactored so that it can take advantage of overlapped graph fetch operations and the GPUGraphCache. Opened issue #7504 to track it.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 4, 2024 18:12
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2024

Commit ID: 650e504

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2024

Commit ID: 202388c

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title add gb.TemporalLayerNeighborSampler. [GraphBolt] gb.TemporalLayerNeighborSampler. Jul 4, 2024
@mfbalin mfbalin changed the title [GraphBolt] gb.TemporalLayerNeighborSampler. [GraphBolt] gb.TemporalLayerNeighborSampler Jul 4, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2024

Commit ID: 3ad0da8

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin force-pushed the gb_temporal_layer_sampler branch from 2fd0945 to 202388c Compare July 5, 2024 02:51
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: 2b917a5722612e15d08dc5afb7f9b5e8898d67e3

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: 6366e9e

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: f0c05f4

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: ec09676

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: d6c7545

Build ID: 9

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: 562b760

Build ID: 10

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2024

Commit ID: fc42a41

Build ID: 11

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 9, 2024

@frozenbugs This PR is the simplest one. Feel free to take a quick look.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 9, 2024

Commit ID: 9e8d481

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 9e546f3 into dmlc:master Jul 9, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_temporal_layer_sampler branch July 9, 2024 08:53
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants