-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphBolt] gb.TemporalLayerNeighborSampler
#7503
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To trigger regression tests:
|
mfbalin
changed the title
add
[GraphBolt] Jul 4, 2024
gb.TemporalLayerNeighborSampler
.gb.TemporalLayerNeighborSampler
.
mfbalin
changed the title
[GraphBolt]
[GraphBolt] Jul 4, 2024
gb.TemporalLayerNeighborSampler
.gb.TemporalLayerNeighborSampler
mfbalin
force-pushed
the
gb_temporal_layer_sampler
branch
from
July 5, 2024 02:51
2fd0945
to
202388c
Compare
@frozenbugs This PR is the simplest one. Feel free to take a quick look. |
frozenbugs
approved these changes
Jul 9, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: TemporalNeighborSamplerImpl needs to be refactored so that it can take advantage of overlapped graph fetch operations and the GPUGraphCache. Opened issue #7504 to track it.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes