Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][io_uring] Improve detection and simplify code. #7515

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 10, 2024

Description

Eliminate redundant check and unnecessary nested if. Improve detection by checking if underlying system supports file read requests via io_uring. This is to fix test failure on machines with old kernel versions.

TODO for later: Overlap disk reads with memcpy operations after reads are done by submitting 2 times group_size_ operations into the submission queue. After the second submission, wait for the first set of submissions.

TODO for later: Consider using readv so that we don't need memcpy.

@chang-l tested the code (big thanks!), our detection logic works for old kernel versions that have io uring but does not support the file read operations.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 10, 2024 21:01
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin requested a review from chang-l July 10, 2024 21:03
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2024

Commit ID: 85bfcf8

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2024

Commit ID: 0db100c

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2024

Commit ID: 2c652e2

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 10, 2024

Commit ID: daa2c1e

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 11, 2024

Commit ID: 4f09f2e

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin requested review from Rhett-Ying and removed request for chang-l July 11, 2024 01:34
@mfbalin mfbalin merged commit eb352e9 into dmlc:master Jul 11, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_io_uring_detection_improvement branch July 11, 2024 12:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants