Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Cache policy replace fix. #7520

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 12, 2024

Description

Replace looks up a key with Read. Read marks the key as in use after lookup if it exists. Insert didn't mark the keys in use.

Until after the keys have actually been inserted into the feature cache (not policy), we actually need to mark them in use. Thus, changing the default value of the reference count to 1 fixes Insert not marking the keys as in use. After that, we need to unmark them as not in use after the embeddings are inserted into the inmemory feature embedding cache.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 12, 2024 09:33
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 12, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 12, 2024

Commit ID: 98658d7

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 2ebd7eb into dmlc:master Jul 16, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cache_policy_replace_fix branch July 16, 2024 04:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants