Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fix issue on torch 2.3.1 #7521

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 12, 2024

Description

Looks like register_fake is not available in 2.3.1, I mistakenly assumed in #7493 that it is. This should fix one issue our user was having in https://discuss.dgl.ai/t/distdgl-v2-4-built-from-source-training-error/4474/3.

PyTorch documentation on deprecation: https://pytorch.org/docs/2.4/library.html#torch.library.impl_abstract

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the Release Candidate Candidate PRs for the upcoming release label Jul 12, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 12, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 12, 2024

Commit ID: 786c543

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 4d497d1 into dmlc:master Jul 13, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_torch_231_fix branch July 13, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Candidate Candidate PRs for the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants