Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Refactor and extend FeatureStore. #7558

Merged
merged 7 commits into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 21, 2024

Description

We don't need to expose Feature.read_async and related functions in FeatureStore. This functionality will let us access the stored Features in FeatureFetcher and we will be able to call the hidden read_async functions as the user will mostly keep
FeatureStore objects around, not Features. Moreover, it is possible to provide the implementations of read, update and other functions if we expose a __getitem__ method, increasing code reuse.

It will also make the examples look better and our components easier to use.

if args.gpu_cache_size > 0 and args.storage_device != "cuda":
feature._features[("node", None, "feat")] = gb.GPUCachedFeature(
feature._features[("node", None, "feat")],
args.gpu_cache_size,
)

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 21, 2024 17:47
@mfbalin mfbalin marked this pull request as draft July 21, 2024 17:47
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: 6689153

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review July 21, 2024 21:44
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: cad4b6e

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 21, 2024

Commit ID: 060001d

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: ce5870e

Build ID: 4

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 725b17c

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title [GraphBolt] Access Features from FeatureStore. [GraphBolt] Refactor and extend FeatureStore. Jul 22, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: ea35d4f

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: a3324cd

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Jul 22, 2024
@mfbalin mfbalin merged commit d775ab1 into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_feature_store_get_feature branch July 22, 2024 05:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants