Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Avoid initializing CUDAContext in DataLoader workers. #7560

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 22, 2024

Description

When torch::Tensor::is_pinned() is called, it initializes the CUDA context. If the process is a worker, is_pinned should not even call that function and return false. #7559 requires it for the tests.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs July 22, 2024 05:34
@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Jul 22, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 22, 2024

Commit ID: 7358766

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit c218b19 into dmlc:master Jul 22, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_dataloader_worker_fix branch July 22, 2024 06:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants