Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Overhaul unique_and_compact CPU. #7613

Merged
merged 9 commits into from
Jul 30, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Jul 29, 2024

Description

Using the new std::atomic_ref for portable compare and swap implementation. See #7614.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 29, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 29, 2024

Commit ID: babf73f

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 29, 2024

Commit ID: f1685ac

Build ID: 2

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Jul 29, 2024

Commit ID: f1685ac

Build ID: 2

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

@Rhett-Ying We need C++20 compliant compiler for this PR to go forward. As you can see, Windows supports parallel unique and compact implementation as well instead of the serial code.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 29, 2024

Commit ID: e62c9ee

Build ID: 3

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying removed the request for review from peizhou001 July 30, 2024 05:29
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: 399ce38e9709282df63b23c0b37cf11b9fdf9d8b

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: f3087a1

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: 8991388

Build ID: 6

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: a15a3db

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: 7659d08

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

graphbolt/CMakeLists.txt Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 30, 2024

Commit ID: b07f4cc

Build ID: 9

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit be2873a into dmlc:master Jul 30, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_unique_and_compact_overhaul branch July 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants