Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixing Bug in test_change_etype_to_canonical_etype.py::test_hetero_graph Test. #7622

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

drivanov
Copy link
Contributor

Description

The following tests are failing:

FAILED tests/tools/test_dist_part.py::test_pipeline_arbitrary_chunks[1-8-4-1-1] - dgl._ffi.base.DGLError: [18:50:07] /opt/dgl/dgl-source/third_party/dmlc-core/src/io/local_filesys.cc:209: Check failed: allow_null:  LocalFileSystem::Open "/tmp/tmp0xrr_81s/partitioned/part...
FAILED tests/tools/test_dist_part.py::test_pipeline_arbitrary_chunks[1-4-4-1-1] - dgl._ffi.base.DGLError: [18:50:17] /opt/dgl/dgl-source/third_party/dmlc-core/src/io/local_filesys.cc:209: Check failed: allow_null:  LocalFileSystem::Open "/tmp/tmpelqoxwt6/partitioned/part...
FAILED tests/tools/test_dist_part.py::test_pipeline_arbitrary_chunks[3-4-4-3-3] - dgl._ffi.base.DGLError: [18:50:28] /opt/dgl/dgl-source/third_party/dmlc-core/src/io/local_filesys.cc:209: Check failed: allow_null:  LocalFileSystem::Open "/tmp/tmpunrp3p5y/partitioned/part...
FAILED tests/tools/test_dist_part.py::test_pipeline_arbitrary_chunks[1-4-2-1-1] - dgl._ffi.base.DGLError: [18:50:39] /opt/dgl/dgl-source/third_party/dmlc-core/src/io/local_filesys.cc:209: Check failed: allow_null:  LocalFileSystem::Open "/tmp/tmpwikubuyu/partitioned/part...

The root cause of this issue is the attempt to access featdata_key.shape when featdata_key is None.
The fix is quite obvious.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Commit ID: eb3b8d690de632cc595ed49dd5c7b32fbce2d447

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 31, 2024

Commit ID: 05534e1

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 7, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 7, 2024

Commit ID: bd059d0

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@frozenbugs frozenbugs self-requested a review August 8, 2024 02:21
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 8, 2024

Commit ID: 8f4d70f5e8a82eea9b4d76753387556297b6d173

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 7aa8a50 into dmlc:master Aug 8, 2024
2 checks passed
@drivanov drivanov deleted the exchange_feature branch August 8, 2024 15:50
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants