Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Change hash table for performance. #7631

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 1, 2024

Description

1.5x faster compared to phmap. This hash table is used across the industry for its excellent performance. See the benchmark results in https://martin.ankerl.com/2022/08/27/hashmap-bench-01/#benchmark-results-table for reference. We chose to use tsl::robin_map for our use case after trying out a few alternatives.

@frozenbugs 50% performance improvement is not small so I am hoping it is fine for me to add this hash table dependency.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs August 1, 2024 14:32
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 1, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 1, 2024

Commit ID: b561317

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

.gitmodules Show resolved Hide resolved
@frozenbugs
Copy link
Collaborator

Replacing phmap sounds good to me, if we need both, we need to think twice.

@mfbalin mfbalin merged commit f724ec0 into dmlc:master Aug 2, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_tsl_robin_map branch August 2, 2024 10:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants