Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Optimize CopyTo performance. #7634

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 1, 2024

Description

https://pytorch.org/tutorials/intermediate/pinmem_nonblock.html

According to this tutorial, pinning before copying is not a requirement for non_blocking copies. However, when the data is pinned, it is possible to run the copies in a separate stream, this optimization can be enabled later. This should bring down the regression test runtimes for cpu-cuda.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Aug 1, 2024
@mfbalin mfbalin requested a review from frozenbugs August 1, 2024 16:36
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 1, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 1, 2024

Commit ID: e701fd1

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit dfd4915 into dmlc:master Aug 1, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_copy_to_opt branch August 1, 2024 17:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants