Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on torchdata. #7638

Merged
merged 10 commits into from
Aug 6, 2024
Merged

Remove dependency on torchdata. #7638

merged 10 commits into from
Aug 6, 2024

Conversation

frozenbugs
Copy link
Collaborator

@frozenbugs frozenbugs commented Aug 2, 2024

Description

Starting from torchdata 0.8, the datapipe related code will be removed, we temporarily move the dependency to torch.data, to see whether more deprecation will happen in torch.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: a72a018

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@frozenbugs frozenbugs changed the title Replace torchdata. Remove dependency on torchdata. Aug 2, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 6bb3596

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 0b570a4fe453118afa7b207177b796f8359d14fc

Build ID: 3

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: ebcb109ff18140f5b4050bf10aaaeb18f24b7828

Build ID: 4

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@frozenbugs frozenbugs requested a review from mfbalin August 2, 2024 03:47
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 865f073

Build ID: 5

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@frozenbugs frozenbugs force-pushed the datapipe branch 2 times, most recently from 8e791bd to 1f1316d Compare August 2, 2024 03:53
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 2ec0696c26e45b5e4f773390005e9b02b07c1366

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 1f1316d

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 2e4956c

Build ID: 8

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator

mfbalin commented Aug 2, 2024

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: 2e4956c

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 2, 2024

Commit ID: bdf9947

Build ID: 10

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 378f22625f0c06a4872061fb906619420efa4f2a

Build ID: 11

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 4d5ec4a129f71fc9ceb01495ffd83973c48d0c99

Build ID: 12

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 6955591

Build ID: 13

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

Copy link
Collaborator

@Rhett-Ying Rhett-Ying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. please remember to remove other torchdata related code such as setup.py, dev.yaml.template and others after merging this PR.

@frozenbugs frozenbugs merged commit 26ff09f into dmlc:master Aug 6, 2024
1 of 2 checks passed
@frozenbugs frozenbugs deleted the datapipe branch August 6, 2024 03:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants