Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Use async for GPUGraphCache. #7707

Merged
merged 8 commits into from
Aug 16, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 15, 2024

Description

We hide the synchronization latencies for GPUGraphCache functions as well.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Aug 15, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: f73729c

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as draft August 15, 2024 19:40
@mfbalin mfbalin removed the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Aug 15, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: bd8c04515e9fd44438b3fffae475808b84eaaa87

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: 65128ec0ab60b9b951580e3ed8c07595109de934

Build ID: 3

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: b040bc984ceee71908e4e60aca4682163927e031

Build ID: 4

Status: ❌ CI test failed in Stage [Torch GPU Unit test].

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review August 15, 2024 23:05
@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Aug 15, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: bf65e86e48a007f883a72330ab6e5dd50888dbf5

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: 435b34eee37319c3849a1d4922a0450668f8cf6a

Build ID: 6

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: d047e056703667d726bbe90cdb00efcb15c15b3a

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: dc99e51b03446399e110753a22817faeae39f6f6

Build ID: 8

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 15, 2024

Commit ID: 16f749f9fd94e36a90e1b4df2da1089bd729228d

Build ID: 9

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 9c874d0 into dmlc:master Aug 16, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_gpu_graph_cache_async branch August 16, 2024 00:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants