[GraphBolt] Fix hetero sampling bug with single fanout. #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
added
the
expedited
|
To trigger regression tests:
|
frozenbugs
reviewed
Aug 20, 2024
| for i in range(11): | ||
| nodes = {"u": torch.randint(10, (100,), device=F.ctx())} | ||
| sampler(nodes, fanouts=torch.tensor([-1])) | ||
| # Should reach here without crashing. |
There was a problem hiding this comment.
Thanks for fixing. Better not rely on crash for unit test. Try assert something.
There was a problem hiding this comment.
What should I assert in this test? I took the crashing code and made it into a test. I thought adding this test is better than not adding it?
There was a problem hiding this comment.
Fix the crash is great. For test_sample_neighbors_hetero_single_fanout, you can assert the sampled number of node is expected or similar.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code was simply wrong. I don't know why the tests didn't catch it.
Fixes https://discuss.dgl.ai/t/neighbour-sampling-on-cpu-crashes-for-graphbolt-heterographs/4521.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes