[GraphBolt] CachedFeature can handle hetero features now.
#7731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
added
the
expedited
|
To trigger regression tests:
|
mfbalin
changed the title
CachedFeature can handle hetero features.CachedFeature now can handle hetero features.
mfbalin
changed the title
CachedFeature now can handle hetero features.CachedFeature can handle hetero features now.
Rhett-Ying
reviewed
Aug 26, 2024
| ref = a[feature_key].read(ids) | ||
| val = cached_a[feature_key].read(ids) | ||
| torch.testing.assert_close(ref, val, rtol=0, atol=0) | ||
| assert cached_a[feature_key].miss_rate < 0.69 |
There was a problem hiding this comment.
why is 0.69? should we add comment here?
There was a problem hiding this comment.
It is just how it is. I tested both the cpu and the gpu and less than 0.69 miss rate is expected.
Rhett-Ying
reviewed
Aug 26, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please feel free to remove inapplicable items for your PR.
Changes