[GraphBolt][CUDA] Expose UniqueAndCompact offsets.
#7789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfbalin
added
the
expedited
|
To trigger regression tests:
|
frozenbugs
reviewed
Sep 9, 2024
| @@ -299,10 +293,25 @@ UniqueAndCompactBatched( | |||
| // Utilizes a sort based algorithm, the mapped id of a vertex part of the | |||
| // src_ids but not part of the unique_dst_ids will be monotonically increasing | |||
| // as the actual vertex id increases. Thus, it is deterministic. | |||
| return UniqueAndCompactBatchedSortBased(src_ids, dst_ids, unique_dst_ids); | |||
| auto results3 = | |||
There was a problem hiding this comment.
Why results3 & results4?
There was a problem hiding this comment.
Because the world_size>1 code path is only supported for the Map based implementation. So the 4th argument is not returned by the sort based implementation. So we modify the output to fill the 4th output ourselves.
There was a problem hiding this comment.
Since the code path works only when world_size=1, we simply partition the whole unique_nodes as [0, unique_nodes.size(0)] to a single rank so that the output is valid for all codepaths, even though it won't be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards implementing #7273.
Tests will be in a follow-up PR.
Checklist
Please feel free to remove inapplicable items for your PR.
Changes