Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt][CUDA] Get world_size=1 somewhat for cooperative sampling. #7796

Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Sep 12, 2024

Description

Towards implementing #7273

The implementation of cooperative sampling is mostly done. The code path is tested with a single process for now while the expected outputs are not tested yet.

There will be multiple follow-up PRs to polish the code, test more throughly, add more documentation and get everything working.

I have to merge to master often because otherwise there will be too much code. When it is done, I will make sure the code is in good shape.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin added the expedited if it doesn't affect the main path approve first to unblock related projects, and review later label Sep 12, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 12, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 12, 2024

Commit ID: 53118ba

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title [GraphBolt][CUDA] Get world_size=1 working for cooperative sampling. [GraphBolt][CUDA] Get world_size=1 somewhat for cooperative sampling. Sep 12, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 12, 2024

Commit ID: 14e2cb1

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 189b83c into dmlc:master Sep 12, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_cuda_cooperative_sampling_single_process_tested branch September 12, 2024 21:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expedited if it doesn't affect the main path approve first to unblock related projects, and review later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants