Skip to content
This repository has been archived by the owner on Feb 1, 2020. It is now read-only.

[NHWC] InferShape Layout conversion fix. #372

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Conversation

srkreddy1238
Copy link
Member

No description provided.

@tqchen
Copy link
Member

tqchen commented Feb 13, 2018

just want to confirm the NHWC weight convention and what is the intended behavior. @yuruofeifei @yidawang @yzhliu can you confirm?

@tqchen tqchen merged commit 520461f into dmlc:master Feb 18, 2018
@tqchen
Copy link
Member

tqchen commented Feb 18, 2018

cc @piiswrong This seems to be a common weight convention for NHWC used in packages.

@masahi
Copy link
Member

masahi commented Feb 18, 2018

@tqchen I don't know if it is common in other frameworks, but this was the format I figured out while I was trying to vectorize NHWC convolution.

Suppose the filter layout is [num_filter, height, width, in_channel]. Then I would vector-load from input channel dimension. But since input channel axis is one of the reduce axes, I cannot do data parallel multiply-add-accumulate. Instead, I need to reduce over vector elements.

@yzhliu
Copy link
Member

yzhliu commented Apr 5, 2018

@tqchen I'm implementing a more general layout system, in new design, weight has its own layout, e.g., OIHW (oc, ic, height, width). We can talk about it later.
For the changes here, honestly I don't know whether it is a common weight convention for NHWC either.

@yzhliu yzhliu mentioned this pull request Apr 18, 2018
abergeron pushed a commit to abergeron/nnvm that referenced this pull request May 31, 2018
* [DOC] Add Build TVM Runtime on Device section

Add Build TVM Runtime on Device section

* Add echo USE_RPC=1>> config.mk in code-block

Add echo USE_RPC=1>> config.mk in Build TVM Runtime on Device section

* [DOC] Fix small problem
abergeron pushed a commit to abergeron/nnvm that referenced this pull request May 31, 2018
larroy pushed a commit to larroy/nnvm that referenced this pull request Feb 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants