-
Notifications
You must be signed in to change notification settings - Fork 745
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add InjectSvg property to Logo theme object
Resolves #3893 Co-authored-by: Daniel Valadas <info@danielvaladas.com> Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
- Loading branch information
1 parent
08a8bda
commit ab2a618
Showing
4 changed files
with
141 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
<%@ Control Language="C#" AutoEventWireup="false" Inherits="DotNetNuke.UI.Skins.Controls.Logo" ViewStateMode="Disabled" Codebehind="Logo.ascx.cs" %> | ||
<asp:hyperlink id="hypLogo" runat="server"><asp:image id="imgLogo" runat="server" enableviewstate="False" /></asp:hyperlink> | ||
<%@ Control Language="C#" AutoEventWireup="false" Inherits="DotNetNuke.UI.Skins.Controls.Logo" ViewStateMode="Disabled" CodeBehind="Logo.ascx.cs" %> | ||
<asp:HyperLink ID="hypLogo" runat="server"> | ||
<asp:Image ID="imgLogo" runat="server" EnableViewState="False" /> | ||
<asp:Literal ID="litLogo" runat="server" EnableViewState="False" /> | ||
</asp:HyperLink> |
ab2a618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me...
Some coding concepts in there I don't recognize.
What is this? An inline function?
new CacheItemArgs(cacheKey, DataCache.PortalCacheTimeOut, DataCache.PortalCachePriority, svgFile),
(_) =>
ab2a618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's just a lambda function where I've named the argument
_
to indicate it's not used (and the parenthesis for a single argument lambda are optional, so it could be(_)
or just_
). These are equivalent:and
args => 4
ab2a618
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff!