DNN-8867: improving folder permission caching. #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the solution still not optimal as there are no single calls to purge a specific older permissions from the Cache in the library and any change in the folders will purge all folders permissions through cache dependency. I tried to do this with minimal changes so as not to introduce new features and major changes to the system. BTW, QA team must do some performance measurements on this change to see the effects on regular site operations.
|
George, please remove "with (NoLock)" hints. I haven't been able to notice minimal performance improvements (tested on SQL Server 2012) and the risk to affect proper results is way to high and in a platform product like DNN, you cannot test all use cases. There are way better options to improve database performance than using critical edge case options like this. |
|
changes looks good, and merge into development branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving folder permission caching.