Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amended d06a05289d3372dfaf7205956ab01929fbf61ebb #2811

Merged
merged 2 commits into from
May 22, 2019

Conversation

daguiler
Copy link
Contributor

Fixes #2594

Summary

Extends solution implemented in d06a052 to getChildren and search methods. With this fix, child disabled pages can be selected as well.

@daguiler daguiler added esw Issues reported by ESW team or Evoq customers Type: Bug labels May 21, 2019
@daguiler daguiler added this to the 9.4.0 milestone May 21, 2019
@daguiler
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@ohine
Copy link
Contributor

ohine commented May 22, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchelsellers
Copy link
Contributor

@ohine Is this build failure due to the other stuff? DO we merge this one?

@ohine
Copy link
Contributor

ohine commented May 22, 2019

@mitchelsellers The new pipeline wasn't enabled on the release branch at the time this PR came in. It is now, and I triggered it to run again lastnight with Build v9.4.1-pr2811.1.17528 and it succeeded.

As for the publish artifacts pipeline, that's been disabled due to the compilation errors due to the case-sensitivity issue which is still being researched. Hopefully we will get that item fixed up and then re-enable that optional pipeline.

If we want this in v9.4.0, yes please merge it into release/9.4.x

@mitchelsellers mitchelsellers merged commit 8e34b7e into dnnsoftware:release/9.4.x May 22, 2019
@daguiler daguiler deleted the bug/dnn-30377 branch June 17, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esw Issues reported by ESW team or Evoq customers Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants