Fix for Custom Authentication Providers #2814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valadas
approved these changes
May 24, 2019
ohine
approved these changes
May 24, 2019
This was referenced Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2749 documents a loss of display of the authentication provider when using a non-standard DNN Provider when the DNN Provider is not included.
It appears that Pull Request #1897 moved the location whereby the login control is displayed, this changed the behavior that resulted in any custom providers not displaying unless the DNN.
This PR reverts that portion of this change. Long-term, this might not be the best solution, but this should restore functionality for users in the time being.
For those on 9.3, 9.3.1, or 9.3.2 a temporary workaround would be to remove the
Visible="false"from line 13 of /DesktopModules/Admin/Authentication/login.ascx