Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Console and Module Creator installation #3521

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Fixed Console and Module Creator installation #3521

merged 1 commit into from
Jan 27, 2020

Conversation

daguiler
Copy link
Contributor

Fixes #3367

Summary

Excludes Console and Module Creator from SetCorePackageVersions stored procedure.

@daguiler daguiler requested a review from donker January 25, 2020 22:25
@daguiler
Copy link
Contributor Author

Upgrade test passed:

pr-3521-upgrade

@daguiler
Copy link
Contributor Author

Install.aspx test passed:

pr-3521-install-aspx-1

@daguiler
Copy link
Contributor Author

InstallWizard.aspx test passed:

pr-3521-installwizard-aspx-1
pr-3521-installwizard-aspx-2

valadas
valadas approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since those do have manifests.

@valadas valadas added this to the 9.5.0 milestone Jan 26, 2020
@mitchelsellers mitchelsellers merged commit 0cc3479 into dnnsoftware:develop Jan 27, 2020
@daguiler daguiler deleted the fix-module-creator branch January 27, 2020 16:24
@danchaseCTS
Copy link

Confused, I saw something that said Module Creator was no longer included, maybe I have the dates wrong - but also, there's still a "Develop" menu option on modules in 9.9, so I'm not sure if I'm supposed to install Module Creator myself from their github, or if this was supposed to work. Also, does not mention how I would fix and use module creator? Would I re-unzip to get install.aspx back, and just re-run it?

@valadas
Copy link
Contributor

valadas commented Apr 3, 2021

This PR was before we separated Module Creator from Platform.
We did forget to remove that menu item though, I just created #4579 to handle that.
If you do want to install Module Creator you can grab the release from https://github.com/DNNCommunity/Dnn.ModuleCreator/releases and install it just like any other extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdukes bdukes bdukes approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

@donker donker Awaiting requested review from donker

Assignees
No one assigned
Labels
Area: Platform > Admin Modules Priority: Medium Type: Bug
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

Module Creator crashes
5 participants
@daguiler @danchaseCTS @valadas @bdukes @mitchelsellers