Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvement PersonaBar pages treeview on Expand/Collapse #3533

Merged
merged 1 commit into from
Feb 2, 2020

Conversation

nadeem-akhtar-nu
Copy link
Contributor

@nadeem-akhtar-nu nadeem-akhtar-nu commented Feb 2, 2020

Fix bug #3532

Summary

  • Update store method was repeating called for each tree view node with the same parameters.
  • Optimize call to this update store method once per process as parameters remains constant.

Measurements

Action Baseline (ms) Baseline avg. Improve (ms) Improve avg. Improvement
Expand node 59,358 59,227.80 6,032 5,685.60 10.42 X
-- 59,573 5,512
-- 61,184 5,631
-- 58,579 5,775
-- 57,445 5,478
Collapse node 55,476 53,868.40 825 754.20 71.42 X
-- 52,227 695
-- 54,076 716
-- 54,947 794
-- 52,616 741

@david-poindexter david-poindexter added this to the 9.5.1 milestone Feb 2, 2020
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks @nadeem-akhtar-nu

@nadeem-akhtar-nu nadeem-akhtar-nu changed the title Performance improvement Admin.PersonaBar pages treeview on Collapse/E… Performance improvement PersonaBar pages treeview on Expand/Collapse Feb 2, 2020
@david-poindexter david-poindexter modified the milestones: 9.5.1, 9.5.0 Feb 2, 2020
@valadas valadas merged commit 5d4b5dc into dnnsoftware:develop Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants