Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pagesize for site management #3555

Merged

Conversation

SCullman
Copy link
Contributor

@SCullman SCullman commented Feb 8, 2020

This PR improves Site Management (#3085) for setups with a lot of portals (>>50).

Summary

Change is trivial as it just increases the pagesize from 10 to 100. The request will take now aout 100ms instead of about 30ms, which is still reasonable.

This should not close the linked issue. But it impoves the handling until a PR with pagination like in Eventlog is provided.

Risk

Smaller setups with just a few portals will see a longer list.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stop-gap enhancement- thank you @SCullman

@david-poindexter david-poindexter merged commit eab9498 into dnnsoftware:develop Feb 9, 2020
@valadas valadas modified the milestones: 9.5.1, 9.6.0 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants