-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug build to lerna #3596
Add debug build to lerna #3596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks @donker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
I didnt merge this because the Compress images / build (pull_request) failed with the error 'The repository 'http://security.ubuntu.com/ubuntu cosmic-security Release' does not have a Release file.' @valadas any ideas on that? |
hmm, yes and no, Azure pipelines is succeeding, the github action to minimize images if failing, I will have to take a look at it, I will take a look when I come back from Orlando... That being said, if there is any rush in merging this, i can force it if needed, just ping me up, all the reset passes. |
@donker it's not letting me rebase this branch on git checkout adddebug
git fetch --all
git rebase upstream/adddebug # assuming your dnnsoftware branch is named upstream
git push --force-with-lease origin adddebug # assuming your donker branch is named origin |
All green now, merging this. |
This was overlooked in the last Lerna/Yarn overhaul. The user must be able to target a local dev site with the Lerna build. It is currently missing as it only runs in production mode.