Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better feedback in export #3698

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Apr 22, 2020

When trying to export a module, we write a file to disk. If this fails the error the user sees is non-descript. This PR allows the error message to bubble up to the end user.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mitchelsellers mitchelsellers merged commit a56c7a0 into dnnsoftware:release/9.6.0 Apr 23, 2020
@donker donker deleted the fixexport branch April 24, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants