Fixed user role icons not showing #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bdukes
approved these changes
Apr 24, 2020
valadas
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Yeah, this webpack loader changed at some point, and we must have missed making these changes in React Common…
Well I did submit a PR to change that on all the instances I could find, must have missed this one since it is not in the import stack at the top but in the middle of code. Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3619
Summary
To be honest, I can't really explain the internals of why this code change fixes this issue. What I know is that the way modules are exported/imported evolved and now it's mandatory to specify the default object for modules like this one, which is essentially a directory on disk.
This fixes both the Users panel and the Roles panel.