Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/resource manager #3709

Conversation

zyhfish
Copy link
Contributor

@zyhfish zyhfish commented Apr 29, 2020

Fix #3708

@ashishpd
Copy link
Contributor

Hi Everyone - This PR is coming from DNN Corp. We are open sourcing a new module to be used in the DNN Platform named Resource Manager. This module has a modern way to manage folder and files in DNN. The feature-set matches that of Digital Asset Management with some limitations. The PR has been approved for submission by DNN's CEO, Andy Tryba.

Enjoy!

@mitchelsellers
Copy link
Contributor

@valadas @bdukes How do we want to manage this? Accept the PR as-is and submit follow-on PR's for missing features/enhancements?

I'm seeing some verbiage and things that I'd like to clean up. For example, the spelling of Behavior is using the European styling and I would prefer to match current styles etc.

@valadas
Copy link
Contributor

valadas commented Apr 29, 2020

I think the main problem now is it is not building which will block other PRs if we merge it as is and need more time to make it build...

I would maybe:

  1. Create a feature branch for it
  2. On that branch, fix the build
  3. On that branch adjust the manifest so it is locked with 9.7.0 version but the same name as the current one (so it can be an in place replacement)
  4. Ensure the build scripts package it as .resources instead of .zip
  5. Then we merge it on develop and continue working on it from there.

That will allow us to have it live on develop and be an optional replacement for people who are happy with it as it stands, then we can improve it and when we get feature parity (folder settings and stuff) it will simply replace our old one by default just by removing the old one and adjusting our build scripts to package it as a zip

@mitchelsellers
Copy link
Contributor

Ok, what's the best way to do that?

  • Branch off of develop now
  • Rebase this PR to that new branch
  • Approve the PR?

Then continue working?

@valadas
Copy link
Contributor

valadas commented Apr 29, 2020

Hmm, let me merge the latest changes from 9.6.0 into develop, release 9.6.0 and then we branch a feuture branch, sounds good?

@zyhfish
Copy link
Contributor Author

zyhfish commented Apr 29, 2020

I just made changes to fix the items mentioned by @valadas, waiting for the CI building result.

@valadas valadas changed the base branch from develop to feature/resource-manager April 29, 2020 08:17
@valadas valadas added this to the 9.7.0 milestone Apr 29, 2020
@valadas
Copy link
Contributor

valadas commented Apr 29, 2020

Awesome, thanks @ash @zyhfish @mitchelsellers

I just created a branch for it called feature/resource-manager so we can work on that in isolation (pun intended). It fired up a new build but should be the same thing. I need to go to bed, approving and ready to merge as soon as built.

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should merge this and then do small PRs bring it to feature parity and iron out any wrinkles.

@mitchelsellers mitchelsellers merged commit 2cb0b55 into dnnsoftware:feature/resource-manager Apr 29, 2020
@zyhfish zyhfish deleted the feature/resource-manager branch April 30, 2020 00:02
@valadas valadas modified the milestones: 9.7.0, 9.8.0 Jul 29, 2020
@zyhfish zyhfish restored the feature/resource-manager branch October 20, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add resource manager module to replace DAM.
5 participants