-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/resource manager #3709
Feature/resource manager #3709
Conversation
Hi Everyone - This PR is coming from DNN Corp. We are open sourcing a new module to be used in the DNN Platform named Resource Manager. This module has a modern way to manage folder and files in DNN. The feature-set matches that of Digital Asset Management with some limitations. The PR has been approved for submission by DNN's CEO, Andy Tryba. Enjoy! |
@valadas @bdukes How do we want to manage this? Accept the PR as-is and submit follow-on PR's for missing features/enhancements? I'm seeing some verbiage and things that I'd like to clean up. For example, the spelling of Behavior is using the European styling and I would prefer to match current styles etc. |
I think the main problem now is it is not building which will block other PRs if we merge it as is and need more time to make it build... I would maybe:
That will allow us to have it live on develop and be an optional replacement for people who are happy with it as it stands, then we can improve it and when we get feature parity (folder settings and stuff) it will simply replace our old one by default just by removing the old one and adjusting our build scripts to package it as a zip |
Ok, what's the best way to do that?
Then continue working? |
Hmm, let me merge the latest changes from 9.6.0 into develop, release 9.6.0 and then we branch a feuture branch, sounds good? |
I just made changes to fix the items mentioned by @valadas, waiting for the CI building result. |
Awesome, thanks @ash @zyhfish @mitchelsellers I just created a branch for it called feature/resource-manager so we can work on that in isolation (pun intended). It fired up a new build but should be the same thing. I need to go to bed, approving and ready to merge as soon as built. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, we should merge this and then do small PRs bring it to feature parity and iron out any wrinkles.
Fix #3708