-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright header #3801
Copyright header #3801
Conversation
This reverts commit 3f8b47dbeeaf2c8745a070ed35e9a77d1b26cb43. Platform/DotNetNuke.DependencyInjection/DotNetNuke.DependencyInjection.csproj Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj Platform/Modules/HtmlEditorManager/DotNetNuke.Modules.HtmlEditorManager.csproj Platform/Modules/MemberDirectory/DotNetNuke.Modules.MemberDirectory.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/DotNetNuke.Authentication.Facebook.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/packages.config Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/DotNetNuke.Authentication.Google.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/packages.config Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/DotNetNuke.Authentication.LiveConnect.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/packages.config Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/DotNetNuke.Authentication.Twitter.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/packages.config Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider.csproj Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/packages.config Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/DotNetNuke.Providers.AspNetCCP.csproj Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/packages.config Platform/Providers/FolderProviders/DotNetNuke.Providers.FolderProviders.csproj Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj Platform/Tests/DotNetNuke.Tests.AspNetCCP/DotNetNuke.Tests.AspNetCCP.csproj Platform/Tests/DotNetNuke.Tests.Authentication/DotNetNuke.Tests.Authentication.csproj Platform/Tests/DotNetNuke.Tests.Integration/DotNetNuke.Tests.Integration.csproj Platform/Tests/DotNetNuke.Tests.Utilities/DotNetNuke.Tests.Utilities.csproj Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Pages.Tests/Dnn.PersonaBar.Pages.Tests.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Security.Tests/Dnn.PersonaBar.Security.Tests.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Users.Tests/Dnn.PersonaBar.Users.Tests.csproj
This reverts commit a0a7ab64b0671b9bb873d81f84ed3bec859f8867.
This reverts commit 77b2159dec783941ce2a25dfb0f971e5ba601123. Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj
This reverts commit 154d4d6df74de6fea58ecd83324171e0aa40da57. Platform/DotNetNuke.DependencyInjection/DotNetNuke.DependencyInjection.csproj Platform/DotNetNuke.Website.Deprecated/DotNetNuke.Website.Deprecated.csproj Platform/Modules/HtmlEditorManager/DotNetNuke.Modules.HtmlEditorManager.csproj Platform/Modules/MemberDirectory/DotNetNuke.Modules.MemberDirectory.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Facebook/DotNetNuke.Authentication.Facebook.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Google/DotNetNuke.Authentication.Google.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.LiveConnect/DotNetNuke.Authentication.LiveConnect.csproj Platform/Providers/AuthenticationProviders/DotNetNuke.Authentication.Twitter/DotNetNuke.Authentication.Twitter.csproj Platform/Providers/CachingProviders/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider/DotNetNuke.Providers.Caching.SimpleWebFarmCachingProvider.csproj Platform/Providers/ClientCapabilityProviders/Provider.AspNetCCP/DotNetNuke.Providers.AspNetCCP.csproj Platform/Providers/FolderProviders/DotNetNuke.Providers.FolderProviders.csproj Platform/Tests/DNN.Integration.Test.Framework/DNN.Integration.Test.Framework.csproj Platform/Tests/DotNetNuke.Tests.AspNetCCP/DotNetNuke.Tests.AspNetCCP.csproj Platform/Tests/DotNetNuke.Tests.Authentication/DotNetNuke.Tests.Authentication.csproj Platform/Tests/DotNetNuke.Tests.Integration/DotNetNuke.Tests.Integration.csproj Platform/Tests/DotNetNuke.Tests.Utilities/DotNetNuke.Tests.Utilities.csproj Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Dnn.PersonaBar.Extensions.csproj Dnn.AdminExperience/EditBar/Dnn.EditBar.Library/Dnn.EditBar.Library.csproj Dnn.AdminExperience/Library/Dnn.PersonaBar.Library/Dnn.PersonaBar.Library.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Pages.Tests/Dnn.PersonaBar.Pages.Tests.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Security.Tests/Dnn.PersonaBar.Security.Tests.csproj Dnn.AdminExperience/Tests/Dnn.PersonaBar.Users.Tests/Dnn.PersonaBar.Users.Tests.csproj
@bdukes Addition of StyleCop would be AWESOME! I am going to be setting up Sonar Cloud soon so StyleCop will help with scoring there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Based on @mitchelsellers' comment on #3795, I've updated all of the C# file headers.
This PR has a number of helper commits that I used, and then reverted. This should be squashed when merging the PR. However, I left them in place in case anyone thought they were useful and deserved their own PR.
In 810d73a and 096f19c, I added the StyleCop.Analyzers NuGet package to apply the header throughout the solution. I know I've heard at least some folks discuss wanting to add StyleCop (@valadas? @mitchelsellers?), so we could add another PR which cherry-picks those changes (and once we have fewer in-progress PRs, we could apply some other style auto-fixes).
In 826bb68 and e78c244 I upgraded some dependencies that were causing an error when trying to add or update any other NuGet packages. I didn't comb through these commits to reduce unnecessary changes, so they shouldn't be taken as-is, but it highlights a separate issue.