Fixed an issue where it was impossible to upload any icons in page settings. #3865
Conversation
valadas
commented
Jun 27, 2020
valadas
commented
- Resolves about 200 Stylecop warnings
- Fixes an issue where filetypes where detected wrong from mimeTypes (for instance "application/svg+xml" was loogink for files named *.svg+xml" it now properly looks for *.svg files instead).
- Made the validationCode required in the FileUpload common component since it does not work without that prop.
- Fixes Cannot upload svg files for page icons #3863 in a similar fashion as in Fix logo/icon upload in site setting for #3722 #3769 but for the page icons.
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/PagesController.cs
Outdated
Show resolved
Hide resolved
…ntroller.cs Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>
|
Ok, that was strange but all corrections are now done @david-poindexter (gammar-cop) :P If you could re-approve/merge. Thanks for the review :) |
Fixes dnnsoftware#3866 in the same way as in dnnsoftware#3865 and dnnsoftware#3769 The validation code is also needed when creating a new page, not only when editing an existing page.
|
Would this issue been related to anything with trying to upload a file to a page if you are using the file page type? |
|
This fixed 2 issues, one with a missed update on a previous change regarding file uploads. I just saw the issue you mean, I guesses that part was missed, i guess the guy who did this PR (me) did not even know there was another uploader there 😁 The fix should be similar to this PR, if you can create a new issue for it and link to this PR, it would be an easy fix using this code as a reference in that other place. As a workaround in the meantime you could upload the file you want using the site assets and then select the file instead of uploading it in the new page UI. |
|
@valadas okay I can do that! Thank you. |
