Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #3820 Token Provider #3900

Merged
merged 3 commits into from
Jul 11, 2020

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 8, 2020

#3820 had an issue with tests which resulted in some tests not running. Also, it didn't have a config file to apply the new <tokens> section of the web.config to upgraded sites.

@bdukes bdukes added this to the 9.7.0 milestone Jul 8, 2020
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bdukes
Copy link
Contributor Author

bdukes commented Jul 10, 2020

@dnnsoftware/approvers can we get one more approval? Unit Tests are stuck in "partially succeeded" state until this is merged.

@david-poindexter david-poindexter merged commit a005dcb into dnnsoftware:develop Jul 11, 2020
@bdukes bdukes deleted the token-provider-fix branch July 24, 2020 19:44
@valadas
Copy link
Contributor

valadas commented Sep 9, 2020

Hmm, somehow this PR does not live in develop even though it was merged, strange...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants