Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created IApplicationInfo and IApplicationStatusInfo for Dependency Injection #3988

Merged
merged 19 commits into from
Aug 19, 2020
Merged

Created IApplicationInfo and IApplicationStatusInfo for Dependency Injection #3988

merged 19 commits into from
Aug 19, 2020

Commits on Aug 19, 2020

  1. Created IApplicationInfo and IApplicationStatusInfo interfaces and ma… 

    …rked related global apis as deprecated
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a5f14fe View commit details
    Browse the repository at this point in the history

  2. Fixed failing tests

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    04513f6 View commit details
    Browse the repository at this point in the history

  3. Fixed more unit tests

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a733773 View commit details
    Browse the repository at this point in the history

  4. Fixed unit tests

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    90b64f9 View commit details
    Browse the repository at this point in the history

  5. Fixed last set of failing tests

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a81dd60 View commit details
    Browse the repository at this point in the history

  6. Added public default constructor which is required for dependency inj… 

    …ection
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e9dc8a6 View commit details
    Browse the repository at this point in the history

  7. Added missing dependency injection registration of IDnnContext

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a3b51b8 View commit details
    Browse the repository at this point in the history

  8. Fixed up deprecation message to match doc recommendations; Adjusted g… 

    …lobal methods that needed to use new way of handling application status via IApplicationStatusInfo
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    dd68762 View commit details
    Browse the repository at this point in the history

  9. Added INotifyPropertyChanged to the LazyServiceProvider this allow Gl… 

    …obals to listen for when the provider is set and update any dependencies in the Globals class
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    f7ec93f View commit details
    Browse the repository at this point in the history

  10. Updated global to immediately resolve dependencies if it doesn't impl… 

    …ement INotifyPropertyChanged (useful for unit testing). Updated unit tests to mock out IApplicationStatusInfo
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    6136fa4 View commit details
    Browse the repository at this point in the history

  11. Added mocks for DependencyProvider

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a72aecb View commit details
    Browse the repository at this point in the history

  12. Fixed failing unit tests

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    dd3453a View commit details
    Browse the repository at this point in the history

  13. Updated navigation manager to follow same pattern as applicationstatu… 

    …sinfo and resolve it only once
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    0180aee View commit details
    Browse the repository at this point in the history

  14. Added mocks for INavigationManager since it needs to be loaded onts a… 

    …rtup now
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    95ebc7a View commit details
    Browse the repository at this point in the history

  15. Added missing .csproj

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    044bf40 View commit details
    Browse the repository at this point in the history

  16. Updated dependency registration

    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    477b875 View commit details
    Browse the repository at this point in the history

  17. Added the default protected constructor back into the DotNetNukeConte… 

    …xt and deprecated it. This will prevent a breaking change
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1632371 View commit details
    Browse the repository at this point in the history

  18. Updated deprecation notice on protected constructor 

    Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
    @SkyeHoefling @bdukes
    SkyeHoefling and bdukes committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    d27bb3e View commit details
    Browse the repository at this point in the history

  19. Updated deprecation notice in Globals.cs to explain on using Dependen… 

    …cy Injection
    @SkyeHoefling
    SkyeHoefling committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    d1353db View commit details
    Browse the repository at this point in the history