Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up sync this folder and recursive #4072

Conversation

david-poindexter
Copy link
Contributor

Summary

Wire up Sync This Folder and Sync This Folder & Subfolders. It was tested by setting EnableAutoSync = N in HostSettings table. Works like a charm.

Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Do we have any idea what the experience will be for users when this process takes forever?

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and watched behind @david-poindexter back as he was doing it (can't really say I helped other than moral support)...

@david-poindexter
Copy link
Contributor Author

LGTM - Do we have any idea what the experience will be for users when this process takes forever?

It shows an animated ellipsis and grays out the area.

@mitchelsellers mitchelsellers merged commit e46b2c7 into dnnsoftware:feature/resource-manager Sep 9, 2020
@david-poindexter david-poindexter deleted the rm-sync branch September 9, 2020 05:33
@valadas valadas modified the milestones: Future: Minor, 9.8.0 Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants