Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purge Expired JWT tokens task #4126

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Purge Expired JWT tokens task #4126

merged 1 commit into from
Sep 24, 2020

Conversation

donker
Copy link
Contributor

@donker donker commented Sep 24, 2020

This PR introduces a scheduled task in DNN to remove expired JWT tokens using the existing (and until now unused) DeleteExpiredTokens SPROC.

@donker donker added this to the 9.8.0 milestone Sep 24, 2020
mitchelsellers
mitchelsellers approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed double approval

mitchelsellers
mitchelsellers approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see that this was a simple solution.

For those with history, this job will fail all the time as it will not execute in the 30 second timeout that we have. However, I'm not 100% convinced that requires adjustment to this PR.

valadas
valadas approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me.

@david-poindexter david-poindexter merged commit 20ea0d3 into dnnsoftware:develop Sep 24, 2020
@david-poindexter david-poindexter modified the milestones: 9.8.0, 9.7.3 Sep 25, 2020
@donker donker deleted the purgejwt branch September 25, 2020 16:14
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

@bdukes bdukes Awaiting requested review from bdukes

Assignees
No one assigned
Labels
Area: Platform > Dnn.AuthServices.Jwt Type: Enhancement
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@donker @david-poindexter @mitchelsellers @valadas