Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Yarn to 3.4.1 #5569

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Upgrade Yarn to 3.4.1 #5569

merged 1 commit into from
Mar 14, 2023

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Mar 10, 2023

This may fix the build failure of #5568

@bdukes bdukes added this to the 9.11.2 milestone Mar 10, 2023
@david-poindexter
Copy link
Contributor

Looks like the build failed here too. These gremlins! ☹️

@valadas
Copy link
Contributor

valadas commented Mar 10, 2023

Yeah, it probably has to do with Webpack v4 and Node v18. And wndows-latest runners got upgraded to Node v18 since it went LTS. I'll try to take a look at that problem this weekend.

david-poindexter
david-poindexter approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming #5570 resolves the build issues, I still think this PR good to roll in. Thanks @bdukes

valadas
valadas approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too @bdukes feel free to either merge knowing that the build issues is unrelated to this change, or if you want to make sure it works fine in CI, you could review/merge #5570 and then rebase this one on it to double-check...

@david-poindexter david-poindexter merged commit 3db34fd into dnnsoftware:develop Mar 14, 2023
@david-poindexter david-poindexter deleted the upgrade-yarn branch March 14, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

@valadas valadas valadas approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
9.11.2
Development

Successfully merging this pull request may close these issues.
3 participants
@bdukes @david-poindexter @valadas