Updated to remove additional elements #5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donker
approved these changes
Jul 31, 2023
bdukes
approved these changes
Jul 31, 2023
valadas
approved these changes
Jul 31, 2023
valadas
added a commit
to valadas/Dnn.Platform
that referenced
this pull request
Aug 9, 2023
Part of was was done in dnnsoftware#5769 would only work upon upgrades because it belongs in a module and sql objects don't exist before that module is installed. I moved those parts in the ExportImport module upgrade script and it fixed a clean install scenario. Closes dnnsoftware#5789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5552 by introducing the final set of needed changes.
Three additional elements that should have been remove by prior upgrade scripts were updated to be removed
ImportDocumentLibraryCategories,ImportDocumentLibraryCategoryAssoc, andFitsExtendedPropertyPermission.Changes were also made to the
ExportImport_AddUpdateUsersBulkstored procedure to correct a table reference.There are two changes requested in #5552 that I do not believe we should fix at this time, given the nature of where those came from.
[dbo].[aspnet_AnyDataInTables] Invalid object name 'dbo.aspnet_WebEvent_Events' P
[dbo].[aspnet_Users_DeleteUser] Invalid object name 'dbo.aspnet_UsersInRoles' P
They were not included.