Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for PortalSecurity.cs #5780

Merged
merged 33 commits into from
Aug 4, 2023
Merged

Add documentation for PortalSecurity.cs #5780

merged 33 commits into from
Aug 4, 2023

Conversation

david-poindexter
Copy link
Contributor

Summary

Resolves #5779

@david-poindexter david-poindexter added this to the 9.12.1 milestone Aug 4, 2023
@david-poindexter david-poindexter self-assigned this Aug 4, 2023
mitchelsellers
mitchelsellers requested changes Aug 4, 2023
View reviewed changes
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
david-poindexter and others added 16 commits August 4, 2023 00:27
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
a5d1582 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
124b0ea 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
d263e2b 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
10f8d56 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
f214365 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
6d9d83d 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
bc07989 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
ea5a7d4 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
f51fe3a 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
47820f9 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
6bf66df 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
4597127 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
24c4519 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
33445a8 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
893375d 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter @mitchelsellers
Update DNN Platform/Library/Security/PortalSecurity.cs
70920ab 
Co-authored-by: Mitchel Sellers <msellers@Iowacomputergurus.com>
@david-poindexter
Copy link
Contributor Author

Great suggestions @mitchelsellers - really appreciate the assist!

@mitchelsellers
Copy link
Contributor

@david-poindexter ANytime, sorry for the flurry of comments

valadas
valadas reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed a few blank lines to try and resolve the build failure

DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
valadas
valadas reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying again to resolve other blank lines

DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
valadas
valadas reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be the last blank line here... Hopefuly

DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
valadas
valadas approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if the build now succeeds

@david-poindexter
Copy link
Contributor Author

Looks like some periods were missing. I have now corrected them.

@valadas
Copy link
Contributor

valadas commented Aug 4, 2023

This build failure looks like a test fluke, I'll re-run to try...

@valadas
Copy link
Contributor

valadas commented Aug 4, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@valadas valadas merged commit 4b31e41 into dnnsoftware:develop Aug 4, 2023
3 checks passed
@valadas valadas modified the milestones: 9.12.1, 9.13.0 Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchelsellers mitchelsellers mitchelsellers approved these changes

@valadas valadas valadas approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Area: Platform > Library Type: Enhancement
Projects
None yet
Milestone
9.13.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add missing method documentation for DotNetNuke.Security.PortalSecurity
3 participants
@david-poindexter @mitchelsellers @valadas