Fixed a performance issue while navigating folders for providers #5988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating folders using a Folder Provider, this code would refresh the whole providers even though we are not making changes. This PR avoids doing so if EnableFileAutoSync is off, thus improving navigaiton performance.
mitchelsellers
approved these changes
Mar 2, 2024
bdukes
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When navigating folders using a Folder Provider, this code would refresh the whole provider even though we are not making changes.
This PR avoids doing so if EnableFileAutoSync is off, thus improving navigation performance. Users can use the Refresh button to do so manually as needed instead.
This is related to #5969 but does not solve it completely, it improves the navigation of folders experience but there is still the performance issue uploading.