Added Sorting (A-Z) members of roles in PersonaBar #6018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
reviewed
May 1, 2024
| @@ -246,11 +246,11 @@ public HttpResponseMessage GetRoleUsers(string keyword, int roleId, int pageInde | |||
| Localization.GetString("InvalidRequest", Components.Constants.LocalResourcesFile)); | |||
| } | |||
|
|
|||
| var users = RoleController.Instance.GetUserRoles(this.PortalId, Null.NullString, role.RoleName); | |||
| var users = RoleController.Instance.GetUserRoles(this.PortalId, Null.NullString, role.RoleName).OrderBy(x => x.FullName).ToList(); | |||
There was a problem hiding this comment.
Can we move the OrderBy call to the beginning of line 260? This would allows us to only specify it once, and avoid creating another copy of the list.
There was a problem hiding this comment.
yes of course, I fix it.
bdukes
reviewed
May 1, 2024
Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Services/RolesController.cs
Outdated
Show resolved
Hide resolved
bdukes
approved these changes
May 1, 2024
valadas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5994: Sorting (A-Z) members of roles in PersonaBar