Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds lock on calls to ComputeHash to handle concurrency #6061

Merged
merged 1 commit into from
May 31, 2024

Conversation

miguelvaz78
Copy link

Fixes #6059

Summary

Added a new static object that will be used to lock execution across threads.
Both ComputeHash calls were wrapped inside a lock statement so no concurrent executions can be done from different threads. Because of this, the result of the hash function had to be assigned to a new variable that is then used outside of the lock code block.

@miguelvaz78
Copy link
Author

miguelvaz78 commented May 31, 2024 via email

@bdukes bdukes added this to the 9.13.4 milestone May 31, 2024
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@valadas valadas merged commit 29d8668 into dnnsoftware:develop May 31, 2024
3 checks passed
@miguelvaz78 miguelvaz78 deleted the BUG_6059 branch May 31, 2024 16:46
@miguelvaz78
Copy link
Author

Thanks guys!

@valadas
Copy link
Contributor

valadas commented Jun 1, 2024

Thank YOU

TagGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JWT login fails with Unknown error "-1073741816" on ComputeHash
3 participants