Updated Initialize.cs to show modern dotnet4+ versions #6128
Conversation
Removed untested line of code, restored extra newline after close brace `}`. Build works again for me locally.
Sorry about that. Fixed and works for me now (local build). |
|
There is still 2:
|
Are you messing with me? I just fixed the opposite above, "SA1513 - Closing brace should be followed by blank line" I tried this in both VS Code and VS 2022. The only way not to get one of the two errors is ... Oh, so both editors are just inserting whitespace up to the indented cursor. I am supposed to know to spot that and fix it? Okay, sorry, lesson learned. Follow the rules even if you can't see the difference. I think this will fix it, at least I get neither error in VS 2022 when I force the blank lines. |
Replaced whitespace with blank lines to avoid SA1028 and SA1513 simultaneously. :)
| { | ||
| version = "4.8.1"; | ||
| } | ||
|
|
||
| if (release >= 528040) |
There was a problem hiding this comment.
Does this actually work? Doesn't this need to be in descending order? If release is 533320, that should mean 4.8.1, but then it will also be greater than 528040 and 461808, so won't version end up being set to "4.7.2"? Maybe I'm getting this mixed up in my head, but it doesn't read to me like it should work correctly without an else before each if.
There was a problem hiding this comment.
Good catch, it doesn't. It was lazy-converted from using return "4.8";. I'll switch this pull to draft until I can get this done properly. Thanks!
Fixes #6127
Summary
Quick update so that the .NET Framework version shown (e.g. in the PersonaBar) is accurate up to v4.8.1.
Also updated the code style (no more
else) making it easy to added new versions in the future.Reference: DotNet Versions via Code