This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Swap to use getfullargspec instead of getargspec #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelmartinez
suggested changes
Nov 4, 2020
There was a problem hiding this comment.
This looks good ... can you bump the version number as well?
@Xieyan ... can you give this a review as well?
|
For the output updates, it all looks good. |
|
I'll get this version bump in there. I'm still chasing other keyword rendering issues, but this is a step forward. (and I think the SPECIFIC issues I'm seeing are due to bad docstrings as well) |
|
@joelmartinez I'm good with these changes if you folks are. Added the package version update a couple days ago. I think this is g2g. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example CI Run
Output
I ran another CI run to grab original output so we can easily compare here.
Waiting for validation of published docs, but the generated yaml changes definitely look good on the outset.
@joelmartinez take a look?