Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move summary support check right after build #1160

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

crazy-max
Copy link
Member

relates to #1154

This moves summary support check right after build instead of post step and also gives better error message for GHES users instead of internal one used in actions-toolkit: https://github.com/docker/actions-toolkit/blob/7bd4fed6bcfc00fee61e9d307582e8351d7533f7/src/github.ts#L128

@crazy-max crazy-max force-pushed the check-summary-support branch 2 times, most recently from 32248b8 to 076b630 Compare July 2, 2024 10:03
@crazy-max crazy-max marked this pull request as ready for review July 2, 2024 10:58
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit 709dde2 into docker:master Jul 2, 2024
57 checks passed
@crazy-max crazy-max deleted the check-summary-support branch July 2, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant