Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imagetools inspect: keep platform order #972

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

crazy-max
Copy link
Member

follow-up #854

keep order from the manifest and also print formatted image config.

@crazy-max crazy-max marked this pull request as ready for review February 26, 2022 23:57
Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, the added lines are not worth it. Let's just keep it deterministic. JSON is already sorted, just update the printBuildInfos to also do the alphabetical sort.

@tonistiigi tonistiigi added this to the v0.8.0 milestone Mar 4, 2022
util/imagetools/printers.go Outdated Show resolved Hide resolved
util/imagetools/printers.go Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the imagetools-inspect-order branch 2 times, most recently from ec5bdc8 to 198808a Compare March 4, 2022 19:22
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi tonistiigi merged commit 1416bc1 into docker:master Mar 4, 2022
@crazy-max crazy-max deleted the imagetools-inspect-order branch March 10, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants